-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
重构了一下,改得有点多。 #4
Open
cupen
wants to merge
13
commits into
ouqiang:master
Choose a base branch
from
gamedev-embers:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
重构了一下,改得有点多。 #4
+1,095
−6,620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupen
commented
Apr 19, 2019
•
edited
edited
- 构建方案改用 go module (兼容 gopath + vendor),方便 fork 在本地构建。
- 发布改用 docker 以免编译/运行环境差异过大 , 见 make release .
- 配置文件改用 toml 语法,代码层面就不必去手工解析,可以去掉一些 strings.trim 之类的代码。
- 引入 validator, 在 struct tag 里写好断言就行,减少硬编码错误检查。
- 支持 bearychat
- 支持 feishu
- 支持一个事件触发多个通知,比如可同时发到 slack 和 mail 等等,配置多少就发多少。
忘了说,我加了 |
感谢,我有空的时候看一下。 |
@ouqiang 有空看下? |
@ouqiang Hi 你还维护这个项目不? 不介意的话, 我会继续在我的分支上胡改瞎改. |
cupen
force-pushed
the
master
branch
3 times, most recently
from
September 9, 2021 08:43
a02cbd0
to
fb0be1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.