Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inclusion of Neural Prophet in Darts] relaxing dependencies #1129

Closed
hrzn opened this issue Jan 24, 2023 · 3 comments · Fixed by #1145
Closed

[Inclusion of Neural Prophet in Darts] relaxing dependencies #1129

hrzn opened this issue Jan 24, 2023 · 3 comments · Fixed by #1145
Assignees

Comments

@hrzn
Copy link

hrzn commented Jan 24, 2023

Hi team, @ourownstory,
We are considering introducing Neural Prophet in Darts (see: unit8co/darts#1436). Unfortunately the current requirements are a bit too strict for us. Both pytorch lightning and torchmetrics versions are currently pinned. I made a quick test and it seems your unit tests are running fine with Pytorch lightning 1.9.0. Would it be possible to consider relaxing the dependencies (at least with >=, and if possible with older lower bounds)? That could maybe also benefit some of your users.

Cheers,
Julien

@karl-richter
Copy link
Collaborator

Hi Julien, thanks so much for considering the integration of NP into Darts.
I'm looking into the dependencies rn, we can definitely loosen them by a lot! At some point we ran into troubles with a certain version, but that should be fixed now. You can track the progress in #1145.

Best, Karl

@karl-richter karl-richter linked a pull request Feb 1, 2023 that will close this issue
3 tasks
@karl-richter
Copy link
Collaborator

@hrzn, we adjusted the dependencies after some evaluations of the newer package versions. Hope that helps. Let me know if you notice any further roadblocks.

@hrzn
Copy link
Author

hrzn commented Feb 3, 2023

Very nice, looks great, thanks @karl-richter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants