Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning version #1145

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Lightning version #1145

merged 3 commits into from
Feb 1, 2023

Conversation

karl-richter
Copy link
Collaborator

@karl-richter karl-richter commented Feb 1, 2023

🔬 Background

  • The Lightning version requirement is very strict

🔮 Key changes

  • Loosened the requirement for Lightning
  • Loosened the requirement for torchmetrics
  • Remove the rich dependency (no longer used)

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@karl-richter karl-richter added this to the Release 0.5.2 milestone Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 11.5358 12.11 4.98% ⚠️
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 92.9124 98.59 6.11% ⚠️
AirPassengers MAE_val 15.2698 15.4077 0.9%
AirPassengers RMSE_val 19.4209 19.5099 0.46%
AirPassengers Loss_val 0.00195 0.00196 0.92%
AirPassengers MAE 9.82902 9.86947 0.41%
AirPassengers RMSE 11.7005 11.7222 0.19%
AirPassengers Loss 0.00056 0.00057 2.1%
AirPassengers time 4.1031 4.33 5.53% ⚠️
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #1145 (0a3a663) into main (fad0367) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          30       30           
  Lines        4966     4966           
=======================================
  Hits         4479     4479           
  Misses        487      487           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karl-richter karl-richter self-assigned this Feb 1, 2023
Copy link
Collaborator

@judussoari judussoari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@judussoari judussoari merged commit 55c23bb into main Feb 1, 2023
@judussoari judussoari deleted the feature/lightning_version branch February 1, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inclusion of Neural Prophet in Darts] relaxing dependencies
3 participants