-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Major] Glocal Modelling v2 #1008
Conversation
Model Benchmark
|
Model Benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent Work @alfonsogarciadecorral !!
This is a massive contribution and a big upgrade for global-local modeling.
Thank you!
@leoniewgnr Can you please help @alfonsogarciadecorral to get the tests to run, so we can merge this large PR? The issue does not seem connected to this PR, but rather to poetry? @hxyue1 Can you maybe help figure out if this is a poetry misconfiguration? Thank you so much! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 88.40% 88.51% +0.11%
==========================================
Files 38 41 +3
Lines 5105 5329 +224
==========================================
+ Hits 4513 4717 +204
- Misses 592 612 +20 ☔ View full report in Codecov by Sentry. |
Hi @leoniewgnr @hxyue1 ! Just saw this is still not merged, let me know if you have any doubt about anything from the PR! :) |
@alfonsogarciadecorral I finally got to do a deep-dive and found the bug: A model forward pass in time_net was computing AR components twice - once directly and once after stationarizing. Now the performance metrics match! |
|
WORK IN PROGRESS
This PR will include a new set of features for Global-Local Modelling:
Once the implementation is done. We will test the model using retail data.