Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize training time metric #1045

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Normalize training time metric #1045

merged 4 commits into from
Dec 7, 2022

Conversation

karl-richter
Copy link
Collaborator

🔬 Background

  • The training time metric depends on the system performance, but github action workers have varying system specifications.

🔮 Key changes

  • This pr normalizes the training time based on the currently available system specs.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@karl-richter karl-richter changed the title Update compareMetrics.py Normalize training time metric Dec 6, 2022
@karl-richter karl-richter self-assigned this Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

c8e0fa2

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.52798 4.48 -1.06%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 11.7359 11.82 0.72%
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 93.0425 92.06 -1.06%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #1045 (c8e0fa2) into main (66021de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1045   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          21       21           
  Lines        4736     4736           
=======================================
  Hits         4275     4275           
  Misses        461      461           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karl-richter karl-richter added this to the Release 0.5.0 milestone Dec 6, 2022
@karl-richter karl-richter marked this pull request as draft December 6, 2022 03:58
@karl-richter
Copy link
Collaborator Author

This function assumes a linear relationship between training time and CPU performance test (we use the rule of three for calculation). If the relationship is not linear, this might explain why the training times do not always match up.

@karl-richter karl-richter marked this pull request as ready for review December 7, 2022 00:11
@noxan noxan merged commit a450326 into main Dec 7, 2022
@noxan noxan deleted the feature/adjust_time_in_metrics branch December 7, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants