Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] incorporate typing for Conformal class and conformal_predict method #1104

Merged
merged 6 commits into from Jan 9, 2023
Merged

[refactor] incorporate typing for Conformal class and conformal_predict method #1104

merged 6 commits into from Jan 9, 2023

Conversation

Kevin-Chen0
Copy link
Collaborator

Resolves Issue #1103.

@Kevin-Chen0 Kevin-Chen0 added uncertainty P3 Low priority labels Jan 8, 2023
@Kevin-Chen0 Kevin-Chen0 added this to the Release 0.5.2 milestone Jan 8, 2023
@Kevin-Chen0 Kevin-Chen0 requested a review from noxan January 8, 2023 23:01
@Kevin-Chen0 Kevin-Chen0 self-assigned this Jan 8, 2023
@Kevin-Chen0 Kevin-Chen0 mentioned this pull request Jan 8, 2023
Closed
@Kevin-Chen0 Kevin-Chen0 linked an issue Jan 8, 2023 that may be closed by this pull request
[refactor] incorporate typing for Conformal class and conformal_predict method #1103
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023 •
edited

Codecov Report

Merging #1104 (5490497) into main (32c2990) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   90.13%   90.14%           
=======================================
  Files          21       21           
  Lines        4796     4798    +2     
=======================================
+ Hits         4323     4325    +2     
  Misses        473      473
Impacted Files Coverage Δ
neuralprophet/conformal.py 94.23% <100.00%> (+0.23%) ⬆️
neuralprophet/forecaster.py 87.86% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kevin-Chen0 Kevin-Chen0 changed the title [refactor] incorporate typing for Conformal class [refactor] incorporate typing for Conformal class and conformal_predict method Jan 9, 2023
@Kevin-Chen0 Kevin-Chen0 added the status: needs review PR needs to be reviewed by Reviewer(s) label Jan 9, 2023
noxan
noxan approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kevin-Chen0 Kevin-Chen0 added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Jan 9, 2023
@Kevin-Chen0 Kevin-Chen0 merged commit 88c4711 into main Jan 9, 2023
@Kevin-Chen0 Kevin-Chen0 deleted the refactor/conformal-typing branch January 9, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noxan noxan noxan approved these changes

Assignees

@Kevin-Chen0 Kevin-Chen0

Labels
P3 Low priority status: ready PR is ready to be merged
Projects
None yet
Milestone
Release 0.5.1
Development

Successfully merging this pull request may close these issues.

[refactor] incorporate typing for Conformal class and conformal_predict method
3 participants
@Kevin-Chen0 @codecov-commenter @noxan