Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] fix sum of components in 0.6.0 #1350

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[minor] fix sum of components in 0.6.0 #1350

merged 1 commit into from
Jun 14, 2023

Conversation

leoniewgnr
Copy link
Collaborator

@leoniewgnr leoniewgnr commented Jun 13, 2023 •
edited

馃敩 Background

see #1348

馃敭 Key changes

call compute_components with corrected_input

馃毃 Attention

This PR is only for release 0.6.0.
It cannot be merged on the current main as the code changed since then

@leoniewgnr leoniewgnr self-assigned this Jun 13, 2023
@leoniewgnr leoniewgnr added bug Something isn't working status: needs review PR needs to be reviewed by Reviewer(s) and removed bug Something isn't working labels Jun 13, 2023
@leoniewgnr leoniewgnr marked this pull request as ready for review June 13, 2023 00:18
@ourownstory
Copy link
Owner

@leoniewgnr Thank you for creating this for 0.6.0 too.
We need to however change the merge target to a branch release/0.6.1 that was forked off main at the release 0.6.0 state. Would you mind creating such a branch?

@leoniewgnr leoniewgnr changed the base branch from main to release/0.6.1 June 14, 2023 21:13
@leoniewgnr leoniewgnr merged commit cfab7f3 into release/0.6.1 Jun 14, 2023
@leoniewgnr leoniewgnr deleted the fix-comp-sum-060 branch June 14, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ourownstory ourownstory Awaiting requested review from ourownstory

Assignees

@leoniewgnr leoniewgnr

Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leoniewgnr @ourownstory