New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[major] Speed up split_df by vectorizing for loops #1356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoniewgnr
added
the
status: in development
Pull requests which are in development
label
Jun 21, 2023
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #1356 +/- ##
==========================================
- Coverage 89.88% 89.81% -0.08%
==========================================
Files 38 38
Lines 5103 5058 -45
==========================================
- Hits 4587 4543 -44
+ Misses 516 515 -1
|
leoniewgnr
added
status: needs review
PR needs to be reviewed by Reviewer(s)
and removed
status: in development
Pull requests which are in development
labels
Jun 22, 2023
leoniewgnr
changed the title
[major] Speed up split_df
[major] Speed up split_df by vectorizing for loops
Jun 30, 2023
ourownstory
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent Work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔬 Background
This part of a bigger change, where successively NP will be sped up.
Split_df gets very slow, the more IDs are added
🔮 Key changes
The following sub functions are accelerated:
⏩ Speed up in s