Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Removed incorrect comments. #1421

Merged
merged 1 commit into from Sep 19, 2023
Merged

Conversation

thekoc
Copy link
Contributor

@thekoc thekoc commented Sep 19, 2023

馃敩 Background

  • Comments says Disable trend changepoints and Disable seasonality components, but clearly contradict the actual code.

馃敭 Key changes

  • Removed incorrect comments.

馃搵 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@ourownstory
Copy link
Owner

Thank you @thekoc for catching and fixing the wrong comments!

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1421 (6f2bec9) into main (56d9910) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          38       38           
  Lines        5071     5071           
=======================================
  Hits         4558     4558           
  Misses        513      513           

@ourownstory ourownstory merged commit b04e141 into ourownstory:main Sep 19, 2023
11 of 13 checks passed
@ourownstory
Copy link
Owner

@leoniewgnr @SimonWittner @cooperability Merged this PR.

@ourownstory ourownstory changed the title Removed incorrect comments. [docs] Removed incorrect comments. Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants