Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Torch Load #1473

Merged
merged 3 commits into from Nov 7, 2023
Merged

[minor] Torch Load #1473

merged 3 commits into from Nov 7, 2023

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

  • On CPU-only machines, loading gives:
    torch.load RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.

🔮 Key changes

  • Adjusted the load function to pass map_location to torch.load

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1473 (c98b358) into main (ee09742) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   88.32%   88.33%           
=======================================
  Files          38       38           
  Lines        5097     5099    +2     
=======================================
+ Hits         4502     4504    +2     
  Misses        595      595           
Files Coverage Δ
neuralprophet/utils.py 79.77% <100.00%> (+0.11%) ⬆️

@SimonWittner SimonWittner merged commit 7aac3be into ourownstory:main Nov 7, 2023
11 of 12 checks passed
Copy link

github-actions bot commented Nov 7, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 31.6338 31.6338 0.0%
AirPassengers RMSE_val 32.6669 32.6669 0.0%
AirPassengers Loss_val 0.01372 0.01372 0.0%
AirPassengers MAE 6.24137 6.24137 0.0%
AirPassengers RMSE 7.82929 7.82928 -0.0%
AirPassengers Loss 0.00063 0.00063 0.0%
AirPassengers time 16.3138 17.01 4.27% ⚠️
EnergyPriceDaily MAE_val 5.55889 5.55889 -0.0%
EnergyPriceDaily RMSE_val 7.12233 7.12233 -0.0%
EnergyPriceDaily Loss_val 0.02829 0.02829 -0.0%
EnergyPriceDaily MAE 6.37172 6.37172 -0.0%
EnergyPriceDaily RMSE 8.53016 8.53016 -0.0%
EnergyPriceDaily Loss 0.02907 0.02907 -0.0%
EnergyPriceDaily time 24.1818 24.95 3.18% ⚠️
PeytonManning MAE_val 0.3466 0.3466 0.0%
PeytonManning RMSE_val 0.49808 0.49808 0.0%
PeytonManning Loss_val 0.01752 0.01752 0.0%
PeytonManning MAE 0.34735 0.34735 0.0%
PeytonManning RMSE 0.48788 0.48788 0.0%
PeytonManning Loss 0.01457 0.01457 0.0%
PeytonManning time 33.8377 34.14 0.89%
YosemiteTemps MAE_val 0.64178 0.64178 0.0%
YosemiteTemps RMSE_val 0.92787 0.92787 0.0%
YosemiteTemps Loss_val 0.0005 0.0005 0.0%
YosemiteTemps MAE 1.092 1.092 0.0%
YosemiteTemps RMSE 1.89124 1.89124 0.0%
YosemiteTemps Loss 0.00155 0.00155 -0.0%
YosemiteTemps time 93.1884 104.08 11.69%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants