Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Plot_parameter - Yearly Seasonality #1501

Merged
merged 2 commits into from Jan 15, 2024
Merged

[Fix] Plot_parameter - Yearly Seasonality #1501

merged 2 commits into from Jan 15, 2024

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

🔮 Key changes

  • Adjusted x-axis tick labels in plot_yearly

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c45f46) 88.33% compared to head (b938157) 88.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1501   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          38       38           
  Lines        5099     5099           
=======================================
  Hits         4504     4504           
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 5, 2024

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 31.6338 31.6338 0.0%
AirPassengers RMSE_val 32.6669 32.6669 0.0%
AirPassengers Loss_val 0.01372 0.01372 0.0%
AirPassengers MAE 6.24137 6.24137 0.0%
AirPassengers RMSE 7.82929 7.82929 0.0%
AirPassengers Loss 0.00063 0.00063 0.0%
AirPassengers time 10.1633 10.48 3.12% ⚠️
YosemiteTemps MAE_val 0.64178 0.64178 0.0%
YosemiteTemps RMSE_val 0.92787 0.92787 0.0%
YosemiteTemps Loss_val 0.0005 0.0005 0.0%
YosemiteTemps MAE 1.092 1.092 0.0%
YosemiteTemps RMSE 1.89124 1.89124 0.0%
YosemiteTemps Loss 0.00155 0.00155 0.0%
YosemiteTemps time 63.8639 60.18 -5.77% 🎉
EnergyPriceDaily MAE_val 5.55889 5.55889 0.0%
EnergyPriceDaily RMSE_val 7.12233 7.12233 0.0%
EnergyPriceDaily Loss_val 0.02829 0.02829 0.0%
EnergyPriceDaily MAE 6.37172 6.37172 0.0%
EnergyPriceDaily RMSE 8.53016 8.53016 0.0%
EnergyPriceDaily Loss 0.02907 0.02907 0.0%
EnergyPriceDaily time 15.4107 15.31 -0.65%
PeytonManning MAE_val 0.3466 0.3466 0.0%
PeytonManning RMSE_val 0.49808 0.49808 0.0%
PeytonManning Loss_val 0.01752 0.01752 0.0%
PeytonManning MAE 0.34735 0.34735 0.0%
PeytonManning RMSE 0.48788 0.48788 0.0%
PeytonManning Loss 0.01457 0.01457 0.0%
PeytonManning time 22.1203 21.03 -4.93%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

@SimonWittner SimonWittner added the status: needs review PR needs to be reviewed by Reviewer(s) label Jan 11, 2024
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ourownstory ourownstory merged commit b37ed04 into main Jan 15, 2024
11 of 13 checks passed
@ourownstory ourownstory deleted the components_2017 branch January 15, 2024 19:22
@ourownstory ourownstory changed the title [fix] Plot_parameter - Yearly Seasonality [Fix] Plot_parameter - Yearly Seasonality Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants