[devops] Upgrade to lightning 2.0 [WIP] #1514
Open
+579
−566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ourownstory
changed the title
Model Benchmark
\n
Model training plots\n ## Model Training ### PeytonManning  ### YosemiteTemps  ### AirPassengers  ### EnergyPriceDaily  \n |
ourownstory
commented
Jun 20, 2024
pyproject.toml
Outdated
| @@ -16,28 +16,27 @@ classifiers = [ | |||
| Homepage = "https://github.com/ourownstory/neural_prophet" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9" | |||
| typing-extensions = "^4.5.0" | |||
| python = ">=3.9,<3.12" | |||
There was a problem hiding this comment.
Is there a reason that we are no longer including python 3.12?
There was a problem hiding this comment.
I haven't changed that requirement. I'll add it shortly.
There was a problem hiding this comment.
Please make sure that all changes to the requirements are intentional and not merge-artifacts.
|
@ourownstory Not sure where the differences in the metrics are coming from, but I had to cast some variables to float32 to fix some tests which might caused these differences. |
ourownstory
commented
Jun 21, 2024
There was a problem hiding this comment.
Looks like two changes to the if-check have unintentional consequences. @MaiBe-ctrl
neuralprophet/configure.py
Outdated
| @@ -311,12 +311,12 @@ def __post_init__(self): | |||
| self.trend_local_reg = False | |||
|
|
|||
| # If trend_local_reg = True | |||
| if self.trend_local_reg == True: | |||
| if self.trend_local_reg: | |||
There was a problem hiding this comment.
This change looks wrong - see comment in other PR
neuralprophet/configure.py
Outdated
| @@ -398,12 +398,12 @@ def __post_init__(self): | |||
| self.seasonality_local_reg = False | |||
|
|
|||
| # If seasonality_local_reg = True | |||
| if self.seasonality_local_reg == True: | |||
| if self.seasonality_local_reg: | |||
There was a problem hiding this comment.
This also overwrites existing config, which should not happen
ourownstory
commented
Jun 21, 2024
neuralprophet/configure.py
Outdated
| log.error("trend_local_reg = True. Default trend_local_reg value set to 1") | ||
| self.trend_local_reg = 1 | ||
|
|
||
| # If Trend modelling is global. | ||
| if self.trend_global_local == "global" and self.trend_local_reg: | ||
| if self.trend_global_local == "global" and self.trend_local_reg is True: |
There was a problem hiding this comment.
Here, your change was actually correct before:
if self.trend_global_local == "global" and self.trend_local_reg:
neuralprophet/configure.py
Outdated
| log.error("seasonality_local_reg = True. Default seasonality_local_reg value set to 1") | ||
| self.seasonality_local_reg = 1 | ||
|
|
||
| # If Season modelling is global. | ||
| if self.global_local == "global" and self.seasonality_local_reg: | ||
| if self.global_local == "global" and self.seasonality_local_reg is True: |
There was a problem hiding this comment.
Here, your change was actually correct before:
if self.global_local == "global" and self.seasonality_local_reg:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade guide
https://lightning.ai/docs/pytorch/latest/upgrade/from_1_9.html