Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Throw RuntimeError when trying to fit model second time (Fixes #1493) #1531

Merged
merged 3 commits into from Feb 13, 2024

Conversation

ourownstory
Copy link
Owner

see #1493

@ourownstory ourownstory linked an issue Feb 12, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 13, 2024

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 0.64178 0.64178 0.0%
YosemiteTemps RMSE_val 0.92787 0.92787 0.0%
YosemiteTemps Loss_val 0.0005 0.0005 0.0%
YosemiteTemps MAE 1.092 1.092 0.0%
YosemiteTemps RMSE 1.89124 1.89124 0.0%
YosemiteTemps Loss 0.00155 0.00155 0.0%
YosemiteTemps time 62.3085 63.88 2.52%
EnergyPriceDaily MAE_val 5.55889 5.55889 0.0%
EnergyPriceDaily RMSE_val 7.12233 7.12233 0.0%
EnergyPriceDaily Loss_val 0.02829 0.02829 0.0%
EnergyPriceDaily MAE 6.37172 6.37172 0.0%
EnergyPriceDaily RMSE 8.53016 8.53016 0.0%
EnergyPriceDaily Loss 0.02907 0.02907 0.0%
EnergyPriceDaily time 15.6183 16.4 5.0% ⚠️
PeytonManning MAE_val 0.3466 0.3466 0.0%
PeytonManning RMSE_val 0.49808 0.49808 0.0%
PeytonManning Loss_val 0.01752 0.01752 0.0%
PeytonManning MAE 0.34735 0.34735 0.0%
PeytonManning RMSE 0.48788 0.48788 0.0%
PeytonManning Loss 0.01457 0.01457 0.0%
PeytonManning time 21.979 22.49 2.32%
AirPassengers MAE_val 31.6337 31.6337 0.0%
AirPassengers RMSE_val 32.6669 32.6669 0.0%
AirPassengers Loss_val 0.01372 0.01372 0.0%
AirPassengers MAE 6.24136 6.24136 0.0%
AirPassengers RMSE 7.82928 7.82928 0.0%
AirPassengers Loss 0.00063 0.00063 0.0%
AirPassengers time 10.8195 11.39 5.27% ⚠️
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (305de42) 88.41% compared to head (4bb27eb) 88.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files          38       38              
  Lines        5103     5105       +2     
==========================================
+ Hits         4512     4513       +1     
- Misses        591      592       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ourownstory ourownstory merged commit 587b374 into main Feb 13, 2024
9 of 12 checks passed
@ourownstory ourownstory deleted the fix-1493 branch February 13, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error attempting to load model and resume training
1 participant