-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] separate panel uncertainty plot #779
[feature] separate panel uncertainty plot #779
Conversation
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 87.00% 87.06% +0.05%
==========================================
Files 16 16
Lines 4580 4622 +42
==========================================
+ Hits 3985 4024 +39
- Misses 595 598 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks for all your work @LeonieFreisinger! I'll review this shortly and will give you feedback if any. |
@Kevin-Chen0 Thanks a lot!! :) I just added an additional test in test_plotting.py to improve code cov. |
Some improvement ideas:
|
Hey Leonie, maybe you can also modify the uncertainty_estimation_peyton_manning.ipynb example notebook so the |
Also, should the |
@Kevin-Chen0 @ourownstory thanks a lot! |
@ourownstory code check fails because of test_regularization_lagged_regressor. This should be fixed when merging #794 into main and rebasing this branch. |
…tainty_plot' into 710-feature/separate_panel_uncertainty_plot
…tainty_plot' into 710-feature/separate_panel_uncertainty_plot
we could allow the user to decide to plot a specific percentile, instead of hard-coding the mean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all your string formatings, please use f-strings.
Please also remove warnings printouts from the tutorial notebooks. |
…tainty_plot' into 710-feature/separate_panel_uncertainty_plot
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Referencing issue #710
Problem
The plot() function already includes plotting the uncertainty. However, the plot_components() function does not include plotting the uncertainty of yhat as a component.
Solution
Modify the plot_components() function to plot the uncertainty of yhat as a component in a separate panel. Therefore, the matplotlib and plotly version will be modified. The uncertainty will be plotted with the x-axis = 0.5 quantile as reference.