Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support setting custom quantile in plot_parameters() #853

Merged

Conversation

LeonieFreisinger
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger commented Oct 18, 2022

Modify the plot_parameters() function to allow the user to plot a chosen quantile instead of the median.

Therefore, the matplotlib and plotly version will be modified. The quantile will be plotted with absolute value.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #853 (54bdd47) into main (f7e09e4) will decrease coverage by 0.02%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   87.06%   87.03%   -0.03%     
==========================================
  Files          16       16              
  Lines        4622     4627       +5     
==========================================
+ Hits         4024     4027       +3     
- Misses        598      600       +2     
Impacted Files Coverage Δ
neuralprophet/forecaster.py 86.13% <60.00%> (-0.13%) ⬇️
neuralprophet/plot_model_parameters.py 62.88% <100.00%> (ø)
neuralprophet/plot_model_parameters_plotly.py 90.64% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ourownstory
Copy link
Owner

@LeonieFreisinger To simplify things, just change all panels to the specific set quantile (instead of the (default) median).
So, if people call plot_parameters with no args, it plots the parameters of the median.
If they set the quantile, it plots (only) the parameters of the set quantile.

@ourownstory ourownstory changed the title [feature] separate panel for custom quantile in plot_parameters() [feature] Support setting custom quantile in plot_parameters() Oct 18, 2022
@ourownstory ourownstory added this to the Release 0.4.2 milestone Oct 18, 2022
@LeonieFreisinger LeonieFreisinger marked this pull request as ready for review October 19, 2022 16:19
@LeonieFreisinger
Copy link
Collaborator Author

@ourownstory custom quantile for plotting parameters and respective tests are implemented. Would be great, if you could review it.
Thanks!

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ourownstory ourownstory merged commit 8d3a1c1 into ourownstory:main Oct 19, 2022
@LeonieFreisinger LeonieFreisinger deleted the plot_parameters_custom_quantile branch November 30, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants