Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove residuals in forecast dataframe returned by m.predict() #927

Merged
merged 9 commits into from
Nov 22, 2022

Conversation

judussoari
Copy link
Collaborator

*Disabled the plotting option for residuals as well

*Not really needed as residuals are part of basic metrics such as MAE and RMSE

*forecast df is very large, which may overwhelm the user. Now more lean

*Disabled the plotting option for residuals as well

*Not really needed as residuals are part of basic metrics such as MAE and RMSE

*forecast df is very large, which may overwhelm the user. Now more lean
@judussoari judussoari added this to the Release 0.5.0 milestone Nov 1, 2022
@judussoari judussoari self-assigned this Nov 1, 2022
@judussoari judussoari added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #927 (10748bd) into main (e7a7dbd) will increase coverage by 0.24%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
+ Coverage   87.43%   87.68%   +0.24%     
==========================================
  Files          17       17              
  Lines        4466     4433      -33     
==========================================
- Hits         3905     3887      -18     
+ Misses        561      546      -15     
Impacted Files Coverage Δ
neuralprophet/plot_forecast.py 79.22% <66.66%> (+3.89%) ⬆️
neuralprophet/forecaster.py 87.97% <100.00%> (-0.02%) ⬇️
neuralprophet/plot_forecast_plotly.py 91.37% <100.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kevin-Chen0
Copy link
Collaborator

Can you have it pass the flake8 and metrics test? Thanks.

@Kevin-Chen0 Kevin-Chen0 added status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 16, 2022
@noxan noxan added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved labels Nov 18, 2022
@Kevin-Chen0
Copy link
Collaborator

Can you pass the flake8 test by resolving this following issue?

local variable 'notnull' is assigned to but never used

@Kevin-Chen0 Kevin-Chen0 added status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 19, 2022
@judussoari judussoari added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved labels Nov 21, 2022
@ourownstory
Copy link
Owner

In the future we may add a tutorial on how to analyze residuals and what one can learn from them.

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ourownstory
Copy link
Owner

fixed merge commits. ready to merge when tests pass.

@ourownstory ourownstory removed the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 21, 2022
@ourownstory ourownstory added the status: ready PR is ready to be merged label Nov 21, 2022
@Kevin-Chen0 Kevin-Chen0 merged commit 169e0b3 into ourownstory:main Nov 22, 2022
@github-actions
Copy link

169e0b3

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
PeytonManning MAE_val 0.64636 0.64636 -0.0%
PeytonManning RMSE_val 0.79276 0.79276 -0.0%
PeytonManning Loss_val 0.01494 0.01494 -0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 -0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
YosemiteTemps MAE_val 1.72949 1.72948 -0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 -0.0%
YosemiteTemps Loss_val 0.00096 0.00096 -0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 -0.0%
YosemiteTemps RMSE 2.16631 2.16631 -0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@judussoari judussoari deleted the disable_residual branch November 22, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants