Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels in CONTRIBUTING.md #946

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Labels in CONTRIBUTING.md #946

merged 3 commits into from
Nov 22, 2022

Conversation

karl-richter
Copy link
Collaborator

No description provided.

@karl-richter karl-richter added the docs Improvements or additions to documentation label Nov 12, 2022
@karl-richter karl-richter self-assigned this Nov 12, 2022
@github-actions
Copy link

github-actions bot commented Nov 12, 2022

f8ca00c

Model Benchmark

Show benchmark results
Benchmark Metric main current diff
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #946 (b8359fa) into main (135e8b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files          17       17           
  Lines        4433     4433           
=======================================
  Hits         3887     3887           
  Misses        546      546           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kevin-Chen0 Kevin-Chen0 self-requested a review November 15, 2022 23:20
@noxan
Copy link
Collaborator

noxan commented Nov 18, 2022

I like the ideas of labels a lot. Yet I would strongly advocate for a bot to keep our labels on PRs updated. we just saw that in the last core meeting, github has already status indicators built in (e.g. needs review, approved, needs changes) and we should follow those for our labels. Otherwise we have mismatched information and rather cause confusion, my 2 cents. Happy to have a chat on that.

@noxan noxan self-requested a review November 22, 2022 17:52
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to merge the current state as we already use the labels and have anyone propose and discuss changes as follow up pull requests.

@noxan noxan marked this pull request as ready for review November 22, 2022 21:57
@noxan noxan merged commit bba5a67 into main Nov 22, 2022
@noxan noxan deleted the docs/labels branch November 22, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants