Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add tests for configure #983

Merged
merged 6 commits into from
Nov 30, 2022
Merged

[tests] Add tests for configure #983

merged 6 commits into from
Nov 30, 2022

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Nov 23, 2022

Basic tests for training config quantiles initialization.

Motivation: if we refactor the handling of configuration options and their internals it is good to have some test cases to ensure we do not break anything. This is a starting point for more work in this direction and to provide the template for other test cases people can replicate if they work on some of the configuration objects and want some safety net :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #983 (538c90b) into main (bba5a67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files          17       17           
  Lines        4443     4443           
=======================================
  Hits         3906     3906           
  Misses        537      537           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Nov 23, 2022

538c90b

Model Benchmark

Show benchmark results
Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@noxan noxan marked this pull request as ready for review November 23, 2022 22:08
@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 23, 2022
@noxan noxan added this to the Release 0.5.1 milestone Nov 23, 2022
@noxan noxan self-assigned this Nov 28, 2022
Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 🎂 for more tests!

@karl-richter karl-richter added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 30, 2022
@noxan noxan merged commit abf9eb2 into main Nov 30, 2022
@noxan noxan deleted the tests/add-tests-for-configure branch November 30, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants