Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing] Add ConfigEvents type annotations #989

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Nov 24, 2022

Close #953

@noxan noxan linked an issue Nov 24, 2022 that may be closed by this pull request
@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 24, 2022

e592381

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%
YosemiteTemps time 93.44 93.4 -0.04%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
PeytonManning time 11.72 11.7 -0.17%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
AirPassengers time 4.51 4.51 0.0%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #989 (4df76c3) into main (18e206b) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files          18       18           
  Lines        4450     4450           
=======================================
  Hits         3969     3969           
  Misses        481      481           
Impacted Files Coverage Δ
neuralprophet/configure.py 89.81% <ø> (ø)
neuralprophet/df_utils.py 94.72% <50.00%> (ø)
neuralprophet/utils.py 80.06% <66.66%> (ø)
neuralprophet/time_dataset.py 94.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noxan noxan self-assigned this Nov 28, 2022
Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@karl-richter karl-richter added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 30, 2022
@noxan noxan merged commit e592381 into main Nov 30, 2022
@noxan noxan deleted the 953-type-annotations-for-configevents-and-events branch November 30, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotations for ConfigEvents and Events
3 participants