This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
Add CD deploy to docker hub & k8s #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rickmak
suggested changes
Jun 8, 2018
| "auto_merge": false, | ||
| "repository": "oursky/puttyimages-web", | ||
| "environments": ["pandawork"], | ||
| "allowed_rooms": ["deployment", "likecoin-internal"] |
There was a problem hiding this comment.
What is the usage of allowed_rooms?
Sorry, May I know where will the payload is used?
There was a problem hiding this comment.
The payload maybe not necessary, but I cannot trigger deploy with name only.
| env.shell = '/bin/sh -l -c' | ||
| env.user = 'unimportant' | ||
| env.roledefs.update({ | ||
| 'pandawork': ['puttyimage.pandawork.com'] # this is also unimportant |
There was a problem hiding this comment.
Let update the comments to explain why this is unimportant. Instead of leaving it as magic unimportant.
|
We need to document to tell people about the settings... |
|
I am working on it and will close this PR for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects likecoin#23