Refactored BidHistory layout, txnArrow was placed in incorrect row #72
Conversation
|
Layout change breaks BidHistory.test.tsx / @iainnash I can modify the test if you are ok with the change in markup. |
src/components/AddressView.tsx
Outdated
| const username = useZoraUsername(address); | ||
|
|
||
| const addressFirst = address.slice(0, showChars + PREFIX_ADDRESS.length); | ||
| const addressLast = address.slice(address.length - showChars); | ||
|
|
||
| if (username.username?.username) { | ||
| return <span>{`@${username.username.username}`}</span>; | ||
| return <span {...selector}>{`@${username.username.username}`}</span>; |
There was a problem hiding this comment.
Would prefer doing className={} selector or just adding a wrapper class here. Allowing arbitrary props and classnames is a difficult thing to allow in framework code in my experience. You want to totally remove lower level presentational controls since now people can pass in onClick and such.
I’m okay with a dynamic classname but it may be better to just add a class to keep things consistent and allows us to easily search for how 3rd parties are styling this since we know the name of the class.
|
Moving this work over to a new branch: |
the transaction arrow (etherscan link) was positioned so that it appeared to related to the row beneath the one it actually was supposed to be placed in. Changed the markup to correct this.
Also added an optional selector prop to AddressView component so we don't have to wrap a span in a div or another span - but still have a selector to target for styling.