Feature/farcaster feed #284
Conversation
…feature/FarcasterFeed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@jordanlesich is attempting to deploy a commit to the Zora Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
nit: can we remove className here instead of commenting out
turbo.json
Outdated
| @@ -37,6 +37,7 @@ | |||
| "NEXT_PUBLIC_IPFS_GATEWAY", | |||
| "NEXT_PUBLIC_SENTRY_DSN", | |||
| "NEXT_PUBLIC_ZORA_API_KEY", | |||
| "NEXT_FARCASTER_HUB", | |||
There was a problem hiding this comment.
do we need this exposed in the browser? if that's the case you need to prefix with NEXT_PUBLIC otherwise you don't need the NEXT prefix if it's just needed server side.
There was a problem hiding this comment.
Yep. I can do that.
…ng so feed fetch doesn't fail on sub-fetches.
…into feature/FarcasterFeed
| import { CACHE_TIMES } from 'src/constants/cacheTimes' | ||
| import { getFarcasterProfile } from 'src/data/farcaster/queries/farcasterProfile.ts' | ||
|
|
||
| const handler = async (req: NextApiRequest, res: NextApiResponse) => { |
There was a problem hiding this comment.
can we remove this api route now that we're fetching this data on the initial feed query?
| @@ -161,6 +169,8 @@ export const getServerSideProps: GetServerSideProps = async ({ | |||
| `public, s-maxage=${maxAge}, stale-while-revalidate=${swr}` | |||
| ) | |||
|
|
|||
| getFarcasterProfile(3) | |||
There was a problem hiding this comment.
do we need this call to getFarcasterProfile here
|
Deployment failed with the following error: |
Description
Farcaster feed in Builder UI.
Motivation & context
#270
Code review
I added the neverthrow package. @farcaster/hub-nodejs uses neverthrow which returns 'maybe monads' instead of throwing errors. Needed this package to deal with these types. It's only 1.9kb.https://bundlephobia.com/package/neverthrow@6.0.0
Type of change
Checklist