Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebang lines and make them more consistent. #68

Merged
merged 1 commit into from Apr 26, 2020
Merged

Fix shebang lines and make them more consistent. #68

merged 1 commit into from Apr 26, 2020

Conversation

jebrosen
Copy link
Contributor

On linux (I am not sure about macOS), #!/usr/bin/env perl -w attempts to run a program literally named perl -w which does not exist. Shebang lines are now:

  • Moved to the very first line of the file, where they are guaranteed to be found by the shell
  • Always #!/usr/bin/env perl

Scripts that had perl -w now have a use warnings; line.


This should only really be necessary for scripts that might be invoked from other programs i.e. LAI and LTR_Retriever, but this change can benefit anyone who might try to reuse or work with the scripts in bin/.

`#!/usr/bin/env perl -w` attempts to run a program literally named
`perl -w`, which does not exist. Shebang lines are now:

* Moved to the very first line of the file, where they are guaranteed to
  be found by the shell
* Always `#!/usr/bin/env perl`

Scripts that had `perl -w` now have a `use warnings;` line.
@oushujun
Copy link
Owner

Thank you very much for fixing the shebang line!

@oushujun oushujun merged commit 6154a1a into oushujun:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants