-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor inconsistency of parameters in "Get/Set...ForShape" methods of NifFile class #30
Comments
@gavrant There already is a function EDIT: It seems only |
@ousnius Unfortunately for me, my code is a derivative of PyNifly, and PyNifly does this: |
nifly has all the functions you need (it did already for "Get", and does now for "Set"). |
Yes, I know about the other version of GetColorsForShape that accepts a pointer instead of a string. It's just my inner perfectionist complaining about the sole remaining 'named" Get..ForShape in that block of code. |
Almost all "Get/Set...ForShape" methods of NifFile class identify the shape by its pointer:
But a couple of "Colors" methods go with the name of the shape instead:
And this is a bit confusing. I would suggest adding
NiShape* shape
overloads of these two for consistency and predictability.The text was updated successfully, but these errors were encountered: