Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store annotations locally #76

Closed
4 tasks done
Ninjani opened this issue Apr 13, 2021 · 0 comments · Fixed by #99
Closed
4 tasks done

Store annotations locally #76

Ninjani opened this issue Apr 13, 2021 · 0 comments · Fixed by #99
Labels
enhancement New feature or request

Comments

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021 •
edited

Problem

Gooseberry queries Hypothesis for every search and make which is time-consuming and wasteful since many old annotations won't change any more.

Solution

  • Store annotations in database
  • Use last synced time to check for updates
  • Re-implement filtering using all options supported by Hypothesis
  • Refactor to only run hypothesis for sync, updating tags, deleting annotations. Everything else should be offline.

Additional context

See issue #75
@Ninjani Ninjani added the enhancement New feature or request label Apr 13, 2021
Ninjani added a commit that referenced this issue May 14, 2022
@Ninjani
feat(database): make local database of annotations
e50f094 
- add annotations sled tree to store annotation ID: CBOR serialized
annotation
- add filter_annotations function that works on local
annotations

Closes #76
@Ninjani Ninjani mentioned this issue May 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store annotations locally out-of-cheese-error/gooseberry
1 participant
@Ninjani