Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poor readability of highlighted item in light themes #58

Closed
vbauerster opened this issue Jul 2, 2020 · 4 comments
Closed

poor readability of highlighted item in light themes #58

vbauerster opened this issue Jul 2, 2020 · 4 comments

Comments

@vbauerster
Copy link

Hello! I've tried all built-in light themes and they all suffer same issue, that is poor readability of highlighted item in fuzzy pane. Following is InspiredGitHub theme, but others light themes have more or less same issue.

Screenshot-2020-07-02-at-20-43-32.png
@Ninjani
Copy link
Member

Ninjani commented Jul 2, 2020

Hi! It looks like this can be fixed by fiddling around with the color scheme in skim. I'll try to link it to the code highlight theme so everything is consistent. Thanks for bringing this to my attention, will push a fix this week.

@Ninjani Ninjani mentioned this issue Jul 4, 2020
Merged
@Ninjani Ninjani linked a pull request Jul 4, 2020 that will close this issue
Close issue #58 #59
Merged
@Ninjani Ninjani removed a link to a pull request Jul 4, 2020
Close issue #58 #59
Merged
Ninjani added a commit that referenced this issue Jul 4, 2020
@Ninjani
Merge pull request #59 from out-of-cheese-error/skim_color
1cdb05b 
Close issue #58
@Ninjani
Copy link
Member

Ninjani commented Jul 4, 2020

Should be fixed in v0.4.0. Could you try and see if it looks better for you?

@vbauerster
Copy link
Author

It's definitely better now. Thank you!

Screenshot-2020-07-04-at-19-05-50.png

@Ninjani
Copy link
Member

Ninjani commented Jul 4, 2020

Great! Closing the issue then :)

@Ninjani Ninjani closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbauerster @Ninjani