Feature/py platforms #2
Conversation
| ## | ||
| def do_post_build(self, thebuilder): | ||
|
|
||
| BiosInfoGuid = thebuilder.env.GetValue("BIOS_INFO_GUID") |
There was a problem hiding this comment.
Need to document the environment, filenames, and other API contracts. As we use them, we'll need to update to make more generic.
The plug-in pre-build will build BaseTools / FitGen.exe The plug-in post-build will execute FitGen.exe if needed PlatformBuild cleanup Works/tested Adding draft README
out0xb2
force-pushed
the
feature/py_platforms
branch
from
1d56455
to
7e8a415
Compare
|
Hi @out0xb2, I agree with most of your document, specifically that multi repos are definitely the way to go. However, I disagree with the submodule approach. Submodules do a good job expressing upstream dependencies, and are useful for one-way code consumption scenarios. For example, openssl. We depend on it in Edk2 for providing cryptographic algorithms, but there is very little cross-project interaction between TianoCore and openssl. Pretty much we just use what they provide as is. Its an ideal scenario for the use of a submodule. For edk2 and edk2-platforms however, that is definitely not the case. They are both part of one project, TianoCore. The people working on edk2 and edk2-platforms are the same people. We make changes to edk2-platforms and edk2 in parallel. There is a ton of two-way interaction between the code in those two repos. Having those repos locked to specific commit shas is a liability, not a feature. Most TianoCore developers work like I do, master branch on all repos all the time. The case of using specific shas should be the exception... not the rule. |
No description provided.