Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate a replacement occurred #2

Merged
merged 2 commits into from
Apr 28, 2015
Merged

Conversation

kevireilly
Copy link
Contributor

This change tracks whether or not a pattern has been matched in any file. It can later be evaluated by dependents such as https://github.com/outaTiME/grunt-replace

kevireilly added a commit to kevireilly/grunt-replace that referenced this pull request Jan 28, 2015
@outaTiME
Copy link
Owner

Great one pal ... i will check the code and try the new release ...

probably you need to update the docs in applause, then we merge the doc with dependant projects ...

thks !!!

@kevireilly
Copy link
Contributor Author

OK, awesome. I have fixed the issue causing the unit tests to fail and will update the documentation on both in a moment.

Just realized the actual behavior is "Indicate a replacement did not occur". I may want to squash the whole pull request and just submit a new one with everything in one commit.

@outaTiME
Copy link
Owner

Cool,

But the documentation in grunt-replace modules will be auto-generated no update was required, thks ...

I will analyse the code and will release soon (i need to release the dependent modules too grunt-replace / gulp-task-replace/ broccoli-replace / fez-replace)

@kevireilly
Copy link
Contributor Author

Ah, interesting. Because my previous pull-request for grunt-replace added documentation for the verbose option which seems to have been removed from the documentation.

outaTiME added a commit that referenced this pull request Apr 28, 2015
Indicate a replacement occurred
@outaTiME outaTiME merged commit 1dc3ed5 into outaTiME:master Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants