feat(sroar): Add Roaring Bitmap support to Badger #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
changed the title
manishrjain
changed the title
manishrjain
changed the title
manishrjain
added a commit
that referenced
this pull request
Apr 19, 2023
Badger now supports roaring bitmaps. A user can add a key with a uint64 version via WriteBatch. When compacting the data in the background, Badger would merge all these uint64s into sroar . The finalized Bitmap can be queried via a new `GetBitmap` function. Note that there's no deletion for uint64s yet. This works well with other keys in the system. Badger can identify which keys need to be compacted into sroar and which don't. P.S. Fun fact. Almost all of the code (minus the test) was written on the plane to Lisbon: https://twitter.com/manishrjain/status/1584989187589410817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Badger now supports roaring bitmaps. A user can add a key with a uint64 version via WriteBatch. When compacting the data in the background, Badger would merge all these uint64s into sroar . The finalized Bitmap can be queried via a new
GetBitmapfunction. Note that there's no deletion for uint64s yet.This works well with other keys in the system. Badger can identify which keys need to be compacted into sroar and which don't.
P.S. Fun fact. Almost all of the code (minus the test) was written on the plane to Lisbon: https://twitter.com/manishrjain/status/1584989187589410817
This change is