This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(GraphQL): Ensure that a list of scalars remain sorted #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a list of strings, currently Outserv stores them sorted by their fingerprints. Instead, as per the GraphQL spec, we need to maintain their order. This PR achieves that outcome with a new ListType. The list values are binary encoded and stored together as one value. This ensures correct ordering. This means a posting list can only have a maximum of one posting for values (UIDs are stored in bitmaps anyway).
This PR also removes the
typefunc from DQL. Instead, now we usehasfunc for resolving queries with no filters. More work is needed to clean updgraph.typepredicate.chunker interface is now replaced with jsonChunker. That's the only chunker we have after RDF chunker was removed.
This change is