Add a test to ensure that calling Set after Close does not panic #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a previous version of ristretto, we experienced a panic occasionally due to calling Set after Close resulting in a write to the closed setBuf channel. We originally wrote this test as part of a fix on a forked version of Ristretto. Thankfully, on HEAD, this test is no longer failing, so we are submitting it to act as a guard against any regressions in the future.
|
|
|
@manishrjain @jarifibrahim any updates? We'd like to migrate off our fork to the new upstream. |
jarifibrahim
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
hi @josephschorr @jzelinskie 👋 ! Thanks for the PR.
The change looks good to me. I cannot merge this PR because I no longer have write access to this repository.
@akon-dey can review and merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a previous version of ristretto, we experienced a panic occasionally due to calling Set after Close resulting in a write to the closed
setBufchannel. We originally wrote this test as part of a fix on a forked version of Ristretto. Thankfully, on HEAD, this test is no longer failing, so we are submitting it to act as a guard against any regressions in the future.NOTE: The update to
golang.org/x/sysalso fixes a build issue with Golang 1.18 on DarwinThis change is