Add Edge support

[romanlex]

Can filter lower when Edge browser
lowerThan: 'js:Promise',
or
lowerThan: 'Edge',

[garhbod]

When will this be merged?

[davinkevin]

We will need this PR to be merged for some project targeting only evergreen browser.

Thanks ;)

/cc @Neonox31

[Kum0ri]

Hi there,
We need to analize this asap.
Need to test across all browsers because the plugin need to work in ie6 + and all this changes need to be tested in all old browsers.

[davinkevin]

For information, I use it with ie8, seems tout work well 😉

On lun. 25 sept. 2017 à 11:18 Kum0ri ***@***.***> wrote: Hi there, We need to analize this asap. Need to test across all browsers because the plugin need to work in ie6 + and all this changes need to be tested in all old browsers. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4S6r_V2TMhK3_dwMke7KN_7ziNtSqdks5sl2_hgaJpZM4Ns4tc> .

-- Davin Kevin

[danvaz]

Ok, thanks for the input! :)

…

On 25 Sep 2017, at 11:14, Davin Kevin ***@***.***> wrote: For information, I use it with ie8, seems tout work well 😉 On lun. 25 sept. 2017 à 11:18 Kum0ri ***@***.***> wrote: > Hi there, > We need to analize this asap. > Need to test across all browsers because the plugin need to work in ie6 + > and all this changes need to be tested in all old browsers. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#269 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AB4S6r_V2TMhK3_dwMke7KN_7ziNtSqdks5sl2_hgaJpZM4Ns4tc> > . > -- Davin Kevin — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOSCRDRkhStcoA38C_H6odsHioazJWv9ks5sl3zogaJpZM4Ns4tc>.

[karolyi]

@alexprg @brunoamorim what the hell are you guys waiting for with merging with this project?

[karolyi]

@danvaz ?

[Kum0ri]

Hi there @karolyi ,

As said before, we need to check the changes and we didn't found the time to do it.

Tkx,
daniel

[karolyi]

@Kum0ri if that helps, I started using this PR's .js file in my production, it works just fine. I targeted IE11 with it, tested before locally (lucky I still have IE11), and can confirm it works.

[karolyi]

Proof:

[romanlex]

I think that all want see test in ie6 ))) May be you can get screen? I use my version of outdated-browser for all my projects. I don' known why is PR is so long wait approved

PS
All want see test in ie6, but all hasn't ie6

[karolyi]

hmm, maybe I can pull an older IE. I have an XP virtualmachine.

[karolyi]

so I fired up my old XP machine, and IE8 is installed within. however I couldn't test the code since those browsers use such an outdated SSL implementation which my server will not accept.

I guess that's the end of my testing. guys, merge this PR already.

[Deadload]

Added js test for Edge support

[Deadload]

Hey guys,
Merge done, sorry for the delay.
If you can please test it we would appreciate it, and any bug please report back.

thks,
Joao

[esonesson]

When testing this, the notice shows in all browsers I try it in. IE, Edge, Chrome, FF on both Win and Mac. Do you know any solution for it?

[esonesson]

Any news on this? :)

[karolyi]

@esonesson you must have done something wrong. I use this version of the JS file and it works.

[jonadeline]

@esonesson, I experimented the same issue and finally figured out why. I installed through bower so I get the master branch where this PR has not been merged yet, so take care to get the develop branch if you use bower and then use the non minified js file (the patch has not been applied to the minified file). Then it should work correctly.

[baticodes]

I have the same issue as @esonesson and @Bodhiz . In my case I downloaded the last version from Github and as @Bodhiz said only the non minified js file works correctly.

[Awea]

Hi there, tested in Edge / IE 11, Chrome, FF and it works :) Thanks @romanlex

[Saborknight]

Great to see this merged, but why hasn't the minified version been merged along with the non-minified? I was using the minified version, and wondering what I had done wrong when in actual fact the minified version simply doesn't include the changes made to include lowerThan: 'Edge' support...

[GianniObiglio]

After 8 months it would be great to have synchronized version between the minified and non minified version :)

[charlax]

Can we re-open this issue? Edge support is not included in the minified file.