Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves two issues (including #189):
laravel-nova-ui
package. I've copied the buttons from the current Laravel Nova views.->toArray()
call, appended attributes (enabledClass
etc) and relational attributes (children
etc) were being included, causing an unknown column issue when trying to insert the data into the database. Using a->getAttributes()
call resolves this issue while not breaking any existing functionality such as copying with children or as child.I've not tested for backwards compatibility. This may need a Laravel Nova dependency minimum version bump, though in theory as this doesn't depend on Laravel Nova for the buttons anymore it may also be fine.