Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nova >=4.28. #191

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix for nova >=4.28. #191

merged 1 commit into from
Jan 29, 2024

Conversation

Senexis
Copy link
Contributor

@Senexis Senexis commented Jan 12, 2024

This pull request resolves two issues (including #189):

  • Both loading buttons and danger buttons are no longer present in Laravel Nova, instead buttons are being moved to the laravel-nova-ui package. I've copied the buttons from the current Laravel Nova views.
  • Resolves a potential issue when duplicating menu items. Due to the use of the ->toArray() call, appended attributes (enabledClass etc) and relational attributes (children etc) were being included, causing an unknown column issue when trying to insert the data into the database. Using a ->getAttributes() call resolves this issue while not breaking any existing functionality such as copying with children or as child.

I've not tested for backwards compatibility. This may need a Laravel Nova dependency minimum version bump, though in theory as this doesn't depend on Laravel Nova for the buttons anymore it may also be fine.

@Tarpsvo Tarpsvo merged commit ed8e197 into outl1ne:main Jan 29, 2024
@Tarpsvo
Copy link
Collaborator

Tarpsvo commented Jan 29, 2024

Awesome, thanks a ton for the PR! Everything seems solid and it's exactly how I've upgraded other packages as well since the laravel-nova-ui change in Nova. The release went out tagged at 7.1.5. Thanks again and good luck! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants