Call resolveForDisplay method on template fields #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calling
displayUsingmethod on fields that are in templates have no effect. I addedresolveForDisplaycall toPageManagerController getFieldswithout any checks but thats not ideal as edit view does not require this to be called.There is also no way of knowing in
PageManagerController getFieldsmethod which view you are currently on.In Nova's native resource client request query (or body) usually contains that information (ex. https://d.pr/i/O5DZ2J) or by controller method that was invoked.
I added appropriate query param to
getFieldsrequest to differentiate in what view calledgetFields