fix: Passing publish=true in documents.update with published document…

… errors
outline · Feb 24, 2024 · bc3271b · bc3271b
1 parent 7685637
commit bc3271b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/server/routes/api/documents/documents.test.ts b/server/routes/api/documents/documents.test.ts
@@ -3032,6 +3032,7 @@ describe("#documents.update", () => {
         id: document.id,
         title: "Updated title",
         text: "Updated text",
+        publish: true,
       },
     });
     const body = await res.json();

diff --git a/server/routes/api/documents/documents.ts b/server/routes/api/documents/documents.ts
@@ -990,7 +990,10 @@ router.post(
     }
 
     if (publish) {
-      authorize(user, "publish", document);
+      if (document.isDraft) {
+        authorize(user, "publish", document);
+      }
+
       if (!document.collectionId) {
         assertPresent(
           collectionId,