Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support embedded video #1135

Closed
IdrisMiles opened this issue Jan 2, 2020 · 7 comments
Closed

support embedded video #1135

IdrisMiles opened this issue Jan 2, 2020 · 7 comments
Labels
feature Big ideas for the future stale

Comments

@IdrisMiles
Copy link

Hey,

Are there any plans to support embedded video?
It would be great to be able to upload a mp4 video file for example

@tommoor
Copy link
Member

tommoor commented Jan 2, 2020

We're planning on some file attachment support this year, I'm not sure yet whether this will include embedded videos – but it could.

For now your best bet is to upload to YouTube or Vimeo and make the video private/unlisted, you can then paste the link in Outline to get an embedded player.

@tommoor tommoor added feature Big ideas for the future question idea and removed question labels Jan 2, 2020
@DeeGeeTill
Copy link

While this is by no means a good solution, for now we've decided to integrate just the embeds that Google Drive give us. JIC anyone is searching on Google for this, and wants a quick and dirty solution:

  1. Add a new file in the apps/embeds section called Drive.js (or whatever you want to call it) and just add the file https://gist.github.com/DeeGeeTill/5343e777f1a1d25092c700f544b3d5fb
  2. Modify the index.js file as well (see the comment on the gist)

Again, it's a super-quick bodge job that will crash, but it's better than nothing.

To use it, upload a file to Google Drive, click the Share Link button as you would normally and then paste that link into your Outline doc.

It works with most Google Drive files including video.

@tommoor
Copy link
Member

tommoor commented Jan 17, 2020

@DeeGeeTill good stuff, this is exactly why we built the plugin system this way – if you're able to get it stable in the future I'd accept a PR to add support for these to the main codebase

@spacec0de
Copy link

any chance of adding support for video links from Google Drive that embed the same way as YouTube or Vimeo?

@mxzinke
Copy link
Contributor

mxzinke commented Jan 13, 2021

#1804 Should address this, to have support of embedded google drive urls.

@matbrgz
Copy link
Contributor

matbrgz commented Jan 14, 2021

#1804 Definitely could help on this.

@stale
Copy link

stale bot commented Apr 9, 2021

Hey! The issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Please reply here if you wish for the issue to be kept open.

@stale stale bot added the stale label Apr 9, 2021
@stale stale bot closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Big ideas for the future stale
Projects
None yet
Development

No branches or pull requests

6 participants