Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor popover menus to use Reakit #1766

Closed
tommoor opened this issue Jan 4, 2021 · 0 comments · Fixed by #1768
Closed

Refactor popover menus to use Reakit #1766

tommoor opened this issue Jan 4, 2021 · 0 comments · Fixed by #1768
Assignees
@tommoor
Labels
enhancement It would be nice if…

Comments

@tommoor
Copy link
Member

tommoor commented Jan 4, 2021 •
edited

We've been gradually improving the keyboard accessibility of Outline but one place stands out as being a major problem is the popover menus, where a lot of functionality is still kept.

I'd like to start moving to the Reakit framework for controls where possible to ensure we're following best practices and aria standards here. This should be relatively straight forward as the DropdownMenu code is already centralized, and will likely just mean removing a lot of custom logic for menu positioning and state management.
@tommoor tommoor added the enhancement It would be nice if… label Jan 4, 2021
@tommoor tommoor self-assigned this Jan 5, 2021
@tommoor tommoor mentioned this issue Jan 5, 2021
Merged
tommoor added a commit that referenced this issue Jan 14, 2021
@tommoor
fix: Keyboard accessible context menus (#1768)
e8b7782 
- Makes menus fully accessible and keyboard driven
- Currently adds 2.8% to initial bundle size due to the inclusion of Reakit and its dependency, popperjs.
- Converts all menus to functional components
- Remove old custom menu system
- Various layout and flow improvements around the menus

closes #1766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommoor tommoor

Labels
enhancement It would be nice if…
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Keyboard accessible context menus outline/outline
1 participant
@tommoor