Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest role with restricted permissions #2946

Closed
M6Ka7 opened this issue Jan 17, 2022 · 13 comments
Closed

Guest role with restricted permissions #2946

M6Ka7 opened this issue Jan 17, 2022 · 13 comments
Assignees
Labels
enhancement It would be nice if… feature Big ideas for the future paid license pinned Will not be closed by stale bot

Comments

@M6Ka7
Copy link

M6Ka7 commented Jan 17, 2022

If I invite several external users to my outline installation, everyone could see other users who have viewed / edited an article. When you invite external users from company A and from company B they can see each other

  • on articles viewed in the past
  • on articles edited
  • on articles viewed at the moment
  • in the settings menu (groups/members)
  • maybe other pages

which would be an GDPR incident.

To Reproduce
Steps to reproduce the behavior:

  1. Create an external user by inviting per mail
  2. Give the user minimal access (viewer)
  3. Login with "magic link"
  4. Visit settings page and then members or groups
  5. Visit an arbitrary page and click the avatar button to see
    • who is online (now)
    • who viewed this page
    • who edited this page

Expected behavior
External users must not see others to avoid GDPR penalties. There should also be an feature to disable the avatar - button on

  • user
  • role
  • login type
  • global

level and forbid access to settings menu.

If the disabling is not possible, the information should be anonymized e.g.

  • 3 people are watching this article now (instead of User A, User B, User C)
  • 24 people viewed/edited this article.

Screenshots
image
The screenshot is made from an external user which can see other (external users) marked with red rectangle.

image

Outline (please complete the following information):

  • Install: self hosted
  • Version: v0.61.1
@M6Ka7 M6Ka7 added the bug label Jan 17, 2022
@tommoor tommoor added enhancement It would be nice if… and removed bug labels Jan 18, 2022
@Shide
Copy link

Shide commented Jan 20, 2022

I was testing Outline for my company and I've found the same issue here.

MT-167 @moduon

@michaelkarrer81
Copy link

+1 This may be a blocking issue to use outline in my company.

@rafaelbn
Copy link

👍 This is a blocking issue

@tommoor
Copy link
Member

tommoor commented Jan 25, 2022

It sounds like the ask here is for a "guest" role which is being conflated with viewer.

Guests would have much more restricted data access, potentially only being able to access collections that they are explicitly added to and not have access to settings screens. Does this sound right?

@M6Ka7
Copy link
Author

M6Ka7 commented Jan 25, 2022

The guest role seems to be the right direction for me. But does not cover it 100%.

The background is: The General Data Protection Regulation, which applies across the EU, threatens up to €20 million (about $22 million USD) for exposure of sensitive (identifying) data.

I would suggest a global switch analogous to FORCE_HTTPS which can (only) be set in the docker-compose.yml file.
This switch removes the User viewing / viewed menu (image). For any non administrator users.

The switch should also remove the member settings view for non administator users

Maybe there are further pages I have not discovered yet.

@Shide
Copy link

Shide commented Jan 25, 2022

It sounds like the ask here is for a "guest" role which is being conflated with viewer.

Yes.

In my case (I'm evaluation 25 kwnoledge platforms), I have assumed that the Viewer role is the Guest role because all of the other platforms treats "Viewers" as "Guests".

Just for clarify the meaning of Guest for me: An invited "user" that can view/comment content for which they have been invited.

@tommoor tommoor added the feature Big ideas for the future label Jan 27, 2022
@tommoor tommoor changed the title Disable some features when accessing in viewer role to comply GDPR Guest role with restricted permissions Jan 27, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label May 28, 2022
@tommoor tommoor added pinned Will not be closed by stale bot and removed stale labels May 28, 2022
@DioneMentis
Copy link

DioneMentis commented Nov 30, 2022

@tommoor Form this comment above: #2946 (comment)

Guests would have much more restricted data access, potentially only being able to access collections that they are explicitly added to and not have access to settings screens. Does this sound right?

Not having this is a limitation for our team. We have some collections that contain information for our team only. Equally we need to create collections that can have external editors and viewers.

We think Outline is a really great tool! But this limitation and the inability to share just one doc in a collection (with edit permissions) with a team member or guest will probably turn out to be deal breakers for us.

@M6Ka7
Copy link
Author

M6Ka7 commented Jan 10, 2023

@tommoor :
Is there a schedule when this feature would be implemented?
Regarding the label "Enterprise" : Private individuals or associations can also be fined for violations of the GDPR.

@almereyda
Copy link

Maybe an alternative convention can be to hide member email addresses for any user but admins?

This should be much easier to implement than a new role.

The display of the email address fields must be conditional on a permission in both cases.

@tommoor
Copy link
Member

tommoor commented Jan 26, 2024

Maybe an alternative convention can be to hide member email addresses for any user but admins?

This is already the case, the policy is defined here:

allow(User, "readDetails", User, (actor, user) => {

@tommoor
Copy link
Member

tommoor commented Apr 30, 2024

This feature is now released in v0.76.0 Business + Enterprise editions, as well as cloud hosted Outline.

@tommoor tommoor closed this as completed Apr 30, 2024
@ldpl-shrey
Copy link

This feature is now released in v0.76.0 Business + Enterprise editions, as well as cloud hosted Outline.

@tommoor
Are there any plans to enable this feature in the Self-Hosted version also?
If yes, by when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement It would be nice if… feature Big ideas for the future paid license pinned Will not be closed by stale bot
Projects
None yet
Development

No branches or pull requests

8 participants