Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering Documents in Collection #622

Closed
tommoor opened this issue Mar 24, 2018 · 14 comments · Fixed by #1722
Closed

Reordering Documents in Collection #622

tommoor opened this issue Mar 24, 2018 · 14 comments · Fixed by #1722
Assignees
Labels
enhancement It would be nice if… feature Big ideas for the future

Comments

@tommoor
Copy link
Member

tommoor commented Mar 24, 2018

Requested by Ada Support.

The ability to drag and drop to reorder/move documents in a collection.

Related #517

@tommoor tommoor added the enhancement It would be nice if… label Mar 24, 2018
@tommoor
Copy link
Member Author

tommoor commented Mar 25, 2018

This came recommended and looks great if we restrict the sidebar to just reordering: https://github.com/atlassian/react-beautiful-dnd

To move a document to another parent you'd have to use the existing move functionality, that seems reasonable?

@jasonquiz
Copy link

Would be great if we could drag it to another Collection. I find myself trying to do this with out thinking about it and then realize it doesn't work.

@tommoor tommoor added the feature Big ideas for the future label Jan 21, 2019
@natefduncan
Copy link

My team and I have started using Outline and this is a feature that we'd love to be able to use. I know it's probably low on the priority list, but just wanted to let you know that there's more interest out there.

@thomasmalley
Copy link

I think #596 might be related somehow ✌🏼️

@anteprimorac
Copy link
Contributor

@tommoor any progress on this? If you didn't start building this, I am happy to contribute.

@tommoor
Copy link
Member Author

tommoor commented May 22, 2020

No meaningful progress. The API largely supports the functionality already, there is an order property that can be sent.

Previously I've thought that the sidebar UI component would pretty much need rebuilding from scratch to support drag-and-drop, but that is mainly if we also need to support dragging documents between collections and dragging nested documents to different levels.

Whilst that would definitely be nice perhaps the pragmatic path forward is to add just reordering first?

@anteprimorac
Copy link
Contributor

I agree we can iterate on this later to add the ability to move the document to a different collection.

Do you have a workflow, like adding special labels and assigning, set in place for managing issues?

@tommoor
Copy link
Member Author

tommoor commented May 22, 2020

I can assign you if you prefer, I'd say 95% of the time folks offer to help but that a PR never materializes – the curse of open source.

@tommoor
Copy link
Member Author

tommoor commented May 22, 2020

This may work, it has no dependencies:
https://github.com/tajo/react-movable

@anteprimorac
Copy link
Contributor

@tommoor I think react-beautiful-dnd is a better choice in the long run because it supports moving items between two or more droppable lists.

I have started working on this, actually already have a working prototype for the UI part. I am going to create a WIP PR soon.

@matbrgz
Copy link
Contributor

matbrgz commented Jul 29, 2020

Are you considering being able to reorder the collections?

@tommoor
Copy link
Member Author

tommoor commented Jul 29, 2020

Yes, we should allow that for sure, the strategy will have to be different from documents though as the entire document structure for a collection is stored in one place it's easy to do an atomic update – not so much for collections.

An approach using fractional indexes might be sound.

@aam1r
Copy link

aam1r commented Dec 11, 2020

This will be a nice feature addition to organize collections

@tommoor
Copy link
Member Author

tommoor commented Jan 3, 2021

Thanks everyone, this is now live in production and will be in the next docker release:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement It would be nice if… feature Big ideas for the future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants