Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reordering documents in collection #1722

Merged
merged 22 commits into from Dec 31, 2020
Merged

feat: reordering documents in collection #1722

merged 22 commits into from Dec 31, 2020

Conversation

thenanyu
Copy link
Collaborator

@thenanyu thenanyu commented Dec 16, 2020 •
edited

WIP

  • so far, just a sketch of some gap-cursor interactions
  • tuned the interaction to feel more natural by having a larger hover footprint than the visual gap cursor

Inspired by #1283
Closes #622

Quick functional spec of intended re-ordering heuristics

image

@request-info
Copy link

request-info bot commented Dec 16, 2020

Hey there! It looks like you didn't provide much information here. Please consider adding more details about the issue / pr or it will be automatically closed. Thanks for helping us maintain the project!

@request-info request-info bot added the more information needed This issue will be automatically closed unless more details are provided label Dec 16, 2020
@tommoor tommoor changed the title reorder documents in left sidebar by dragging feat: reordering documents in collection Dec 17, 2020
@tommoor tommoor removed the more information needed This issue will be automatically closed unless more details are provided label Dec 24, 2020
@thenanyu thenanyu marked this pull request as ready for review December 29, 2020 04:19
tommoor
tommoor approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing here I want to change that isn't covered in the PR at: #1755 –

We discussed some followups that I think can become separate issues:

  • Fine grain controlled of moving nesting level
  • Drag to sort collection order

@tommoor tommoor merged commit 2cc4518 into develop Dec 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the reorder-documents-dnd branch December 31, 2020 20:51
This was referenced Dec 31, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reordering Documents in Collection
2 participants
@thenanyu @tommoor