feat: progressive web app service worker #1347
Conversation
|
|
chsasank
changed the title
| "cdn.jsdelivr.net", | ||
| "storage.googleapis.com", |
There was a problem hiding this comment.
Can we add this without adding two more third-party dependencies? I really don't want to add the entirety of these two CDN's to the CSP allow-list and I think it would be beneficial to keep dependencies bundled with the application.
There was a problem hiding this comment.
We certainly can host these in outline in public folder or using yarn. But if only you can guide me, where or how, it'll make my life easy :)
| <script type="module"> | ||
| // PWA: https://www.pwabuilder.com/serviceworker | ||
| import 'https://cdn.jsdelivr.net/npm/@pwabuilder/pwaupdate'; | ||
| const el = document.createElement('pwa-update'); | ||
| document.body.appendChild(el); | ||
| </script> |
There was a problem hiding this comment.
The UI that this provides doesn't match the rest of the application, I think we'd need to find a way to have it use the regular toast system that is already built in.
I feel like the knock on affects of potentially serving cached assets and js bundles might be quite significant and unpredictable.
There was a problem hiding this comment.
Sure, this is not very unrelated to the above right? If you can guide me to a tutorial how to do this, I'll implement it. Thanks.
|
Hi @tommoor, I want to revive this PR and make progressive web app to your liking. We can then use this PWA to make both electron (i.e desktop) and android phone apps! Looks like this is going to be future: https://medium.com/pwabuilder/microsoft-and-google-team-up-to-make-pwas-better-in-the-play-store-b59710e487 This is also a good direction because of the fact that outline is based on react and existence of react native! It'd be great if you can guide me through with how you want to get the PWA integration done! I'll also raise an issue asking for help in PWA builder repo. |
|
In terms of closer integration with the build system, it seems there are two webpack plugins that can do almost 99% of the work: https://developers.google.com/web/tools/workbox/modules/workbox-webpack-plugin This would keep all of the config inside of webpack and not need additional files and third party script injection |
|
I was considering writing react component to make PWA easy. What do you think? |
|
I’m not clear on how React is related to be honest..
…On Sun, Sep 27, 2020 at 21:52 Sasank Chilamkurthy ***@***.***> wrote:
I was considering writing react component to make PWA easy. What do you
think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC474TZJZ6G57RR33I4QLLSIAI7JANCNFSM4OYEM4BQ>
.
|
|
I mean a small react component that we can keep in app.js or something will all the features of pwabuilder. Sorry but I'm relatively a noob in js stuff. Don't judge me 🙈 |
|
closing due to inactivity |
Please see discussion here: #1337