Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compress avatar images before upload #1751

Merged
merged 3 commits into from Dec 29, 2020
Merged

Conversation

Maronato
Copy link
Contributor

Since avatar images are never displayed in full size, this PR compresses and reduces them to 256x256.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2020

CLA assistant check
All committers have signed the CLA.

@auto-assign auto-assign bot requested a review from tommoor December 25, 2020 23:05
@Maronato Maronato changed the title Compress avatar images before upload feat: Compress avatar images before upload Dec 25, 2020
@tommoor
Copy link
Member

tommoor commented Dec 25, 2020

Nice, pretty down for this improvement – I suggest that we double the size to 512px to future proof though, that will enable 256x256 @ 2x.

@Maronato
Copy link
Contributor Author

Nice, pretty down for this improvement – I suggest that we double the size to 512px to future proof though, that will enable 256x256 @ 2x.

Done :)

@tommoor tommoor merged commit 89903b4 into outline:develop Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants