Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deleting a collection should not deleted archived documents within #1776

Merged
merged 1 commit into from Jan 8, 2021

Conversation

tommoor
Copy link
Member

@tommoor tommoor commented Jan 7, 2021

closes #1775

@tommoor tommoor requested a review from thenanyu January 7, 2021 06:24
@tommoor
Copy link
Member Author

tommoor commented Jan 7, 2021

@thenanyu make sense to you in terms of desired behavior?

@thenanyu
Copy link
Collaborator

thenanyu commented Jan 8, 2021

This seems like a good patch and worth shipping, but there's a consideration to change the default behavior to archive documents instead of deleting

Then a checkbox can be added in the delete dialog which allows true deletion of included documents

This way we can say something like: "also delete 3 active and 5 archived documents"

@tommoor
Copy link
Member Author

tommoor commented Jan 8, 2021

Yea, I like that – default to a soft delete in the future and make this the hard delete option.

@tommoor tommoor merged commit 34598b3 into develop Jan 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/issue-1775 branch January 8, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a collection deletes archived documents
2 participants