New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document emoji picker #4338
Merged
Merged
Document emoji picker #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorv-mishra
force-pushed
the
feat/4274/emoji-picker
branch
from
October 26, 2022 14:22
0692e60
to
bbcd85f
Compare
apoorv-mishra
commented
Oct 27, 2022
apoorv-mishra
commented
Oct 27, 2022
apoorv-mishra
force-pushed
the
feat/4274/emoji-picker
branch
from
October 29, 2022 17:31
96c9cc5
to
a32c480
Compare
tommoor
reviewed
Nov 1, 2022
apoorv-mishra
force-pushed
the
feat/4274/emoji-picker
branch
from
November 3, 2022 10:08
0e0a560
to
6729b3a
Compare
apoorv-mishra
force-pushed
the
feat/4274/emoji-picker
branch
from
November 15, 2022 13:46
217710c
to
1e5f196
Compare
tommoor
changed the title
Ability to pick and choose emoji for the document
Document emoji picker
Aug 26, 2023
fix: Do not pass unsupported locales to emoji mart
server/migrations/20230815063834-migrate-emoji-in-document-title.js
Dismissed
Show dismissed
Hide dismissed
fix: Size between edit/non-edit mismatching
fix: Forget previous search term on picker close
tommoor
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally done here, please don't merge.
server/migrations/20230827234031-migrate-emoji-in-revision-title.js
Dismissed
Show dismissed
Hide dismissed
very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4274