Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add server side validation schema for apiKeys #4859

Merged
merged 3 commits into from Feb 11, 2023
Merged

refactor: add server side validation schema for apiKeys #4859

merged 3 commits into from Feb 11, 2023

Conversation

elidrissidev
Copy link
Contributor

Refactoring the API Keys API endpoints to use server-side validation schema. Also added tests for the endpoints.

@auto-assign auto-assign bot requested a review from tommoor February 11, 2023 18:15
tommoor
tommoor approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@elidrissidev
Copy link
Contributor Author

@tommoor no problem. Happy to help :)

@tommoor tommoor merged commit 492beed into outline:main Feb 11, 2023
@elidrissidev elidrissidev deleted the refactor/apikeys-server-side-validation branch February 11, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elidrissidev @tommoor