Autorun migrations in community edition #5141
Conversation
server/utils/startup.ts
Outdated
| Logger.warn( | ||
| "Please run `yarn db:migrate` or `yarn db:migrate --env production-ssl-disabled` to run all pending migrations" | ||
| ); |
There was a problem hiding this comment.
| Logger.warn( | |
| "Please run `yarn db:migrate` or `yarn db:migrate --env production-ssl-disabled` to run all pending migrations" | |
| ); |
It's ok, I don't need this and this is only a safety measure for cloud now so we can delete.
server/utils/startup.ts
Outdated
| } catch (err) { | ||
| Logger.warn(chalk.red("Failed to run migrations!")); |
There was a problem hiding this comment.
| Logger.warn(chalk.red("Failed to run migrations!")); |
This is resulting in a double error, seems fine without?
There was a problem hiding this comment.
I believe removing db:migrate from Makefile resolves this. No further action needed?
There was a problem hiding this comment.
I don't think it changes it to be honest, I'm easy either way here
There was a problem hiding this comment.
The first error is logged from within the sequelize cli 🙈
Catching errors centrally within checkMigrations now.
|
Oh, I meant to add we should remove the |
apoorv-mishra
force-pushed
the
fix/4680/autorun-migrations
branch
from
337941e
to
d2ea5d8
Compare
|
awesome feature!!! Thanks @apoorv-mishra, this has always been a pain for me. In particular in a |
Closes #4680