fix: Initials do not display on notification avatars #5803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to
notification.user
being typed as aUser
model but actually being a plain object. To fix, introduced a decorator that allows data returned on models to reference the correct underlying store.This is a poor-mans implementation at the moment, but improves types significantly and lays the foundations for improvements in this area such as lazy-loaded relations, while fixing the bug at hand.