Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Pressing "ESC" while in link editor should return to formatting toolbar #100

Closed
tommoor opened this issue Jul 1, 2019 · 0 comments · Fixed by #150
Closed

Pressing "ESC" while in link editor should return to formatting toolbar #100

tommoor opened this issue Jul 1, 2019 · 0 comments · Fixed by #150
Labels
enhancement New feature or request

Comments

@tommoor
Copy link
Member

tommoor commented Jul 1, 2019

Currently it closes the toolbar altogether

@tommoor tommoor added the enhancement New feature or request label Jul 1, 2019
@tommoor tommoor mentioned this issue May 4, 2020
16 tasks
tommoor added a commit that referenced this issue May 7, 2020
* wip

* WIP

* What a mess

* reorganizing

* history, persistence

* add: Placeholder

* add: Text replacement niceties

* add: smart arrow replacement

* add: read-only mode

* add: Link mark

* add: Bullet list (split on enter not yet working)

* chore: Remove slate packages

* generally moving in the right direction

* add: Ensure trailing paragraph

* fix: Duplicate placeholder if first node is heading

* react component rendering

* cs

* add: basic image

* bold, italic input rules

* add: code input rule

* add: OrderedList

* add: strikethrough

* fix: Split list item on Enter
fix: Preserve empty lines

* fix: List spacing

* remove global style usage

* add: Input rule for links

* fix: Filter onChange callback

* fix: onSave, onSaveAndExit, onCancel callbacks working

* improve inline code

* add: Very basic checkboxes

* fix: Much improved checkbox / checklist behavior

* fix: improve checkbox rendering

* add: Highlight mark

* add: Highlight keymap

* fix: less obnoxious highlight

* add: keymap to create hr

* cleanup

* add: basic code block

* fix: Persist empty paragraphs

* fix: autoFocus
add: focusAtStart, focusAtEnd

* documentation

* fix: drag and drop now uploads image with placeholder

* fix: hard break plugin removing images

* add: Support for pasting files from clipboard

* fix: gapcursor, image upload stuff

* fix: Make markdown shortcut for checklist more flexible

* add: Syntax highlighting, copy to clipboard

* fix: Hide language controls in read only

* Remove old slate components

* fix: Add previously ignored files

* fix: Allow changing value from outside editor #120

* fix: pasting of markdown now working correctly

* remove unused node pasteRules, now handled at doc level

* types

* convert to typescript

* test: upgrade ci box

* test: remove flow step

* fix: Restore markdown paste
fix: Restore focusAtStart
fix: Restore focusAtEnd

* fix: Restore nodeViews

* Type improvements

* add: First pass at menu (working, but ugly)

* Floating toolbar

* add: Floating toolbar

* fix: Floating toolbar scroll position

* fix: Click link in edit mode

* fix: Code highlighting logical error

* add: First pass at block menu

* add: More items to block menu, improved positioning

* fix: Block menu position fixes

* fix: typefaces

* fix: backspace on / should remove block menu

* add: separators

* add: up/dn arrow navigation

* fix: type errors

* add: Image upload from block insert

* fix: Remove deprecated React lifecycle hook

* refactor: moving logic out of Image node

* ux feedback

* refactor

* add: Block insert margin trigger

* add: Backspace at beginning of heading should reset to paragraph

* add: Indented title emoji

* tweaks

* fix: Pasting text onto selection should linkify it

* fix: Heading in formatting toolbar should toggle with paragraph

* fix: Select heading and backspace
add: Heading anchors

* cleanup

* add: heading anchors

* fix: Content disappearing

* fix: misc improvements

* WIP

* fix: Working link toolbar

* add: Enter and Escape handling in link editor

* ts

* fix: Disabled open link button if no link

* fix: SSR support
fix: onClickLink, onClickHashtag

* Arrow navigation

* fix: Up arrow link toolbar

* lint

* fix: Placeholder text conflict

* fix: Allow Tab to move from heading

* add: Code fence support

* fix: code block control styling

* fix: Nested task lists

* fix: Nested list styling tweaks

* remove hack

* fix: Add H3 icon

* fix: Block menu trigger appears when read only

* fix: Checkbox items clickable in readonly

* fix: HR styling

* first pass

* WIP: first pass

* fix: Pasting embed link

* lint

* feat: Zoomable images

* tweaks

* whoopsie

* 10.0.0-0

* fix: Integration

* fix: Placeholder option

* 10.0.0-1

* fix: Allow onKeyDown pass trhough
fix: Link clicking
fix: Image without alt

* 10.0.0-2

* tsc

* 10.0.0-3

* Remove forced heading

* 10.0.0-4

* fix #159 – button type=button

* feat: schema, serializer, parser exports for server

* 10.0.0-5

* fix: getMarkAttrs

* fix #163

* fix: Block menu scrolls outer elements
closes #164

* Fix path to example index.js (#166)

* feat: Prosemirror Tables Support (#154)

* stasdh

* feat: Basic, working, tables. PHEW

* lint

* fix: Inline marks work in table cells

* cleanup

* Move to renderTable

* Restrict blocks in table

* fix: Show only inline edit controls inside of table

* grips

* grip selection

* table toolbar positioning

* table column alignment parsing and serialization

* feat: col alignment

* fix: double click needed to select col
fix: incorrect highlight on table formatting items

* feat: Insert row/col

* refactor: Remove TableNodes file

* fix: table header parse
feat: table shadow when wider than content

* Formatting -> Floating

* padding

* fix: Incorrect break spacing

* 10.0.0-7

* fix: Disable toolbar in code blocks

* fix #100 - esc in link editor should return to formatting

* fix: New row respect row alignment

* closes #165

* 10.0.0-8

* fix: Hide useless block controls in list items

* fix: Render lists in tight style

* perf: avoid re-rendering blockmenu on input

* feat: Add JSON as code highlight option

* fix: Double table border

* 10.0.0-9

* Add missing keyboard shortcuts to lift/sink checkbox lists

* upgrade deps

* fix: Block menu should hint at scrolling

* fix: Shortcut for headings in block menu

* improve placeholder text

* lint: typescript issues with updated markdownit def

* feat: Enter to add row to table

* 10.0.0-10

* fix: Restore headingsOffset option
closes #168

Co-authored-by: Shankar Dhanasekaran <shankardevy@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant