This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: Toolbar maximum update depth exceeded #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
changed the title
zanemcca
added a commit
to sunsama/rich-markdown-editor
that referenced
this pull request
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've still never been able to reproduce on demand it's difficult to know if this fixes the issue entirely, but moving the rendering to a more reactive approach based on ResizeObserver and separating the state of the menu size and position seems like it would uncouple everything that could possibly cause a render loop.
This PR also includes a fix for the toolbar being mispositioned when a selection spans multiple lines and the lower lines of content are shorter than lines above.
tentatively closes #208