This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: allow functional component types #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, currently I only consume the library in a Flow codebase – moving this part to Typescript was a first step in migrating the whole thing, but it makes finding these TS integration issues trickier in the meantime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript was complaining about me passing functional components
React.FC<Props>as the icon for embeds or for tooltips. This change fixed the problem for me locally. I also noticed the second argument ofonShowToast(the stable string/message code) wasn't included in the type definition and added it.